Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to specify whether they want to use POST or GET for pe… #97

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wsalazar-peakactivity
Copy link
Collaborator

…rforming the OC request to the registry

Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think adding a way to force POST is a useful feature, especially in case you have big payloads etc.

  1. Can we handle the scenario where there are more than 1 component and method=GET? I think in that case, we should probably return with an exception or error, as the GET only allows one component.

  2. Can we add some unit or acceptance tests for the various scenarios (empty|GET|POST|GET+multiple components exception)?

  3. Can you update the README for documenting the new method parameter?

Thanks!

@wsalazar-peakactivity
Copy link
Collaborator Author

Absolutely. I'll get back to you in a few days with an updated PR. Thanks.

… is set to GET. Update to README file for httpMethod.
@wsalazar-peakactivity
Copy link
Collaborator Author

This is not ready for review just yet. I meant to push this to my fork but for some reason it got picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants