Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run in docker? #354

Closed
demaniak opened this issue Jan 18, 2017 · 6 comments
Closed

How to run in docker? #354

demaniak opened this issue Jan 18, 2017 · 6 comments
Labels

Comments

@demaniak
Copy link

Does anybody have a sample Dockerfile (or instructions) on how to get this running in a Docker container?

So far OC refuses to start in a Ubuntu-based container (Node 7.5.0). Running outside the container works fine.

The error message is: Registry not started: components_list_get

@matteofigus
Copy link
Member

Hi @demaniak the registry needs to be instantiated in a node app via requiring it as dependency and setting all the configuration. You can find more info in the wiki. If you are already doing it, still,

  1. Take in mind that node 7 is still not supported. Not sure there may be issues there but it's still not covered by our test suites. Definitely something we can improve on our side
  2. The error message sounds like there is a connection problem with S3. Is your docker container able to access the public internet (to access aws's api)? Also, how are you passing the s3 credentials in the registry instantiation? If via environment variables, are you ensuring your container gets them?

We use Docker as well for releasing this at OpenTable and the image is just a quite basic Ubuntu + node 6 + a couple of internal tools and it just starts the app by npm start, so nothing special there.

In case you don't solve, can you share your input js file for starting the registry? In case, I can review.

@demaniak
Copy link
Author

Thank you for the reply @matteofigus .

I am also a bit puzzled by this - there is nothing glaringly obviously wrong.
Some test wget requests to S3 (ran outside the container, and inside the container) seems to work fine.

Will go back and verify some items, and downgrade node.
Will post results here as soon as possible.

@matteofigus
Copy link
Member

I opened a PR for testing node 7 #362 and I confirm something is red there. We'll prioritise some work to get it green ;)

@demaniak
Copy link
Author

Thank you for the reply @matteofigus .

I am also a bit puzzled by this - there is nothing glaringly obviously wrong.
Some test wget requests to S3 (ran outside the container, and inside the container) seems to work fine.

Will go back and verify some items, and downgrade node.
Will post results here as soon as possible.

@matteofigus
Copy link
Member

@demaniak we made some fixes and made node 7 green. If you upgrade to the latest version that may improve things 👍

@matteofigus
Copy link
Member

matteofigus commented Feb 14, 2017

This doesn't seem to be an issue anymore as I haven't heard about it anymore. In case, you can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants