Yarn support

[elboletaire]

The oc client can currently be installed using yarn, as any other npm package. The problem comes when we try to publish a package to a registry; for some reason it complains about dependency issues:

$ yarn global add oc
$ oc add registry https://your.registry.com
$ NODE_ENV=production oc publish my-widgets
Packaging -> ~/src/my-widgets/_package
An error happened when creating the package: oc/template.html compilation failed - Error requiring oc-template: "oc-template-handlebars" not found

I never had an issue before installing a package with yarn, so I'm not really sure why is this happening. For that same reason, I'm not really sure if I should mark this as a bug or as an enhancement.

Anyone has an idea why this is different using yarn?

[mattiaerre]

@elboletaire thanks for pointing that out. I'll have a look at it and let you know.

[mattiaerre]

@elboletaire I've been able to yarn globally install oc and publish a couple of my packages; one that uses handlebars and another one that uses jade. Some more info:

➜  ~ yarn global add oc

➜  oc-hub git:(master) ✗ oc publish oc-feedback-form
Packaging -> /Users/mrichetto/projects/oc-hub/oc-feedback-form/_package
(node:3853) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Compressing -> /Users/mrichetto/projects/oc-hub/oc-feedback-form/package.tar.gz
Publishing -> https://pink-pineapple.herokuapp.com/oc-feedback-form/1.0.3
Published -> https://pink-pineapple.herokuapp.com/oc-feedback-form/1.0.3

node: v6.10.2
oc: v0.37.4

// cc @nickbalestra @matteofigus

[matteofigus]

I can see a difference. In one case you publish one level down your component, in the other it's /src/component.

This could be a bug for the require wrapper in the cli looking to require the peer template module relative to the component instead of the position of where the command is ran.

[mattiaerre]

Interesting, have you been able to publish if you do what I do? Later I will try what you are suggesting and see what happens. Thanks.

On Tue, May 23, 2017 at 14:55 Matteo Figus ***@***.***> wrote: I can see a difference. In one case you publish one level down your component, in the other it's /src/component. This could be a bug for the require wrapper in the cli looking to require the peer template module relative to the component instead of the position of where the command is ran. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#487 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGIC3bdsJFVtpbMf4vl093c4fTIJRBGiks5r81XkgaJpZM4NkGYE> .

-- In theory there is no difference between theory and practice. In practice there is. *Jan L. A. van de Snepscheut*

[matteofigus]

Let me catchup with @nickbalestra about this. I think we established a couple of days ago that there was a bug relative to the cli looking for the template in the wrong path, so it could be related.

[matteofigus]

@elboletaire can you try yarn global remove oc and then a yarn global add oc and retry to run the publish command? I think there is something wrong with your install and perhaps a remove+add can fix. Perhaps, it would be useful to ensure yarn is installed with the latest version as well.

[elboletaire]

@matteofigus if you want I try it, but I guess it's gonna fail, because everywhere where I installed oc client (latest friday was the last time I tried) with yarn failed with the same issue (and that includes docker images from latest node version).

BTW, I'll try it when I arrive at the office

[matteofigus]

Ok... I managed to reproduce. I think #488 is actually a good way to solve it. I'll add my findings there

[elboletaire]

Nice, I was coming here to confirm the issue's still there; glad to see you were able to reproduce it 😃