Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular json handler - tests and improvements #1096

Merged
merged 14 commits into from
Sep 6, 2019

Conversation

matteofigus
Copy link
Member

@kmcrawford this is what I had in mind for the tests. This includes:

  • Added try/catch to the GET endpoint too
  • Added more details inside the error
  • Added acceptance tests for both POST and GET endpoints

Copy link
Member

@kmcrawford kmcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kmcrawford kmcrawford merged commit fba97a9 into circular-json Sep 6, 2019
@kmcrawford kmcrawford deleted the circular-json2 branch September 6, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants