Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent package.json changing when calling oc dev #1165

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Conversation

dipunm
Copy link
Contributor

@dipunm dipunm commented Feb 18, 2020

This addresses issue #796.

Since npm made --save the default behaviour, oc has been modifying the package.json file accidentally. This ensures that the package.json file remains untouched.

Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding.
Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)

Create a new project using oc init hello-world and then delete the following folders if they exist: node_modules, _package.
view the component's package.json file:

  "devDependencies": {
    "oc-template-es6-compiler": "1.1.8"
  }

Now run oc dev .
Notice that the package.json file changed:

  "devDependencies": {
    "oc-template-es6-compiler": "^1.1.8"
  }

Now apply this fix.

Notice that the package.json file remains unchanged.

Closing issues
closes #796

@matteofigus matteofigus merged commit 802d6b8 into master Feb 20, 2020
@matteofigus matteofigus deleted the no-save branch February 20, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version of template-compiler updates without warning
3 participants