Handle scoped packages when removing version #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Fix for #1178 (Scoped packages being incorrectly handled when removing the version)
When stripping the version from a package string, we first separate the base name and directory. This is done so we can separate the scope (if present) from the package name, before using
split
to remove the package's version. Once removed, we return the full package withpath.join
I've moved this code into a
split-version
utility, which is now called bylink-missing-dependencies
andnpm-utils
.Test plan (required)
Unit tests have been added for
split-version.js
to cover the following cases: