remove wrap-cli-callback #1209
Merged
remove wrap-cli-callback #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbazydlo
reviewed
Sep 20, 2021
| @@ -3,7 +3,6 @@ | |||
| const read = require('read'); | |||
|
|
|||
| const strings = require('../../resources/index'); | |||
| const wrapCliCallback = require('../wrap-cli-callback'); | |||
There was a problem hiding this comment.
by doing this aren't we breaking contract for things like this:
https://github.com/opencomponents/grunt-oc/blob/master/tasks/oc-mock.js
There was a problem hiding this comment.
how? in that file it's explicitly passing a callback.
There was a problem hiding this comment.
we've chatted about this, the difference is about programmatic api, however we think that the use-case of not passing a callback in programmatic api does not make any sense. @matteofigus we're thinking of treating this as a non breaking change - is that ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can see
wrap-cli-callbackwas only used for CLI commands where we didn't pass a callback. We can just pass it explicitly oncli/index.jswhen calling yargs, and then we don't need to wrap every command. This also makes it easier to be able to universalify those functions (it would get confused thinking it's a promise if sometimes they get called without a callback).