Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove new references on non-classes #1210

Merged
merged 1 commit into from
Sep 22, 2021
Merged

remove new references on non-classes #1210

merged 1 commit into from
Sep 22, 2021

Conversation

ricardo-devis-agullo
Copy link
Collaborator

Removing new references on functions that return normal objects (not classes), since it's not needed.

@matteofigus
Copy link
Member

One thing about this, is making sure we update the docs like this https://github.com/opencomponents/oc/wiki#setup-a-registry

@ricardo-devis-agullo
Copy link
Collaborator Author

Technically you can still call it with new, but yeah, I'll remove it too.

@ricardo-devis-agullo ricardo-devis-agullo merged commit 4386f6a into master Sep 22, 2021
@ricardo-devis-agullo ricardo-devis-agullo deleted the remove-new branch September 22, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbazydlo pbazydlo pbazydlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardo-devis-agullo @matteofigus @pbazydlo