Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL-CB] move components cache to promises #1258

Merged
merged 6 commits into from
Oct 22, 2021
Merged

[INTERNAL-CB] move components cache to promises #1258

merged 6 commits into from
Oct 22, 2021

Conversation

ricardo-devis-agullo
Copy link
Collaborator

Move components-cache and app-start to promises

@ricardo-devis-agullo ricardo-devis-agullo changed the title [INTERNAL] move components cache to promises [INTERNAL-CB] move components cache to promises Oct 16, 2021
pbazydlo
pbazydlo reviewed Oct 22, 2021
View reviewed changes
src/registry/app-start.ts
callback: Callback<ComponentsDetails | string, any>
): void {
options: Config
): Promise<void> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened with Callback return type?

@ricardo-devis-agullo ricardo-devis-agullo merged commit b74ce3a into callback-to-promises Oct 22, 2021
@ricardo-devis-agullo ricardo-devis-agullo deleted the components-cache-to-promise branch October 22, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbazydlo pbazydlo pbazydlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardo-devis-agullo @pbazydlo