[CB-INTERNAL] move nested renderer to promises #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-devis-agullo
changed the title
pbazydlo
reviewed
Nov 16, 2021
| } | ||
| }; | ||
| export default function nestedRenderer( | ||
| rendererCb: ( |
There was a problem hiding this comment.
How about rendererWithCallback?
pbazydlo
reviewed
Nov 16, 2021
| {} | ||
| ) | ||
| .then(res => { | ||
| console.log('RES:', res); |
pbazydlo
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transforming nested-renderer to promises. When exported in get-component they will be universalified, because they are exported on the ocs, so to not break we need to keep supporting callback cased calls