Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component-retrieved event #164

Merged
merged 7 commits into from
Jan 14, 2016
Merged

New component-retrieved event #164

merged 7 commits into from
Jan 14, 2016

Conversation

matteofigus
Copy link
Member

This is needed for having insight about each component, especially when consuming the registry via the new Batch POST endpoint: #163

@matteofigus
Copy link
Member Author

  • I made some cleanup on the code, just for consistency
  • The event handler is now a singleton module - this allows it to be just required in multiple places for firing events without inject the instance on all the dependent classes, still keeping all the subscriptions. Tests attached
  • The request event contains the body - useful for the new POST endpoint
  • The component-retrieved event is fired and contains information about the component. Tests attached.

@jankowiakmaria can you review?

I apology if it is a big PR containing many things - should have done multiple ones.
Thanks

@jankowiakmaria
Copy link
Collaborator

LGTM - should I merge (the title of PR suggests that not yet)? @matteofigus

@matteofigus
Copy link
Member Author

Yes, sorry

@jankowiakmaria jankowiakmaria changed the title [don't merge yet] New component-retrieved event New component-retrieved event Jan 14, 2016
jankowiakmaria added a commit that referenced this pull request Jan 14, 2016
New component-retrieved event
@jankowiakmaria jankowiakmaria merged commit ae2f529 into master Jan 14, 2016
@jankowiakmaria jankowiakmaria deleted the events branch January 14, 2016 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants