node.js client should accept serverRendering and clientRendering endpoints instead of generic array (breaking change) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
changed the title
matteofigus
changed the title
matteofigus
changed the title
|
lol, travis is trying to lint the minified files |
jankowiakmaria
added a commit
that referenced
this pull request
Jan 29, 2016
node.js client should accept serverRendering and clientRendering endpoints instead of generic array (breaking change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 main breaking changes here.
new Client()is not accepted anymore. Options need to be passed in during initialisation:new Client({ //options });client.configis deprecated and made private and not accessible anymoreclientRenderingandserverRendering. So, when doing server-side rendering with failover, failover request will be able to have client-side rendering friendly url.