Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When data is undefined, registry should 500 #208

Merged
merged 1 commit into from
Mar 15, 2016
Merged

When data is undefined, registry should 500 #208

merged 1 commit into from
Mar 15, 2016

Conversation

matteofigus
Copy link
Member

This happens when a component calls a callback without an error, but also without the data object.
At the moment, in some scenarios, the registry just times-out.

When a view doesn't require a view-model, either an empty object should be called-back as result, or a component should have an empty data field in its package.json (to declare it doesn't require any logic to work).

Example:

module.exports.data = function(cx, cb){
  var data;
  cb(null);
};

@matteofigus
Copy link
Member Author

Can you review this today @mattiaerre or @pbazydlo?

@mattiaerre
Copy link
Member

Hi @matteofigus I am looking at this now ... bear w/ me 😉

@pbazydlo
Copy link
Collaborator

i'm leaving it to you then @mattiaerre

@mattiaerre
Copy link
Member

LGTM

// cc @matteofigus @pbazydlo

mattiaerre added a commit that referenced this pull request Mar 15, 2016
When data is undefined, registry should 500
@mattiaerre mattiaerre merged commit 566e36a into master Mar 15, 2016
@mattiaerre mattiaerre deleted the undefined branch March 15, 2016 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants