Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ace editor + added Accept-Language box #221

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Removed ace editor + added Accept-Language box #221

merged 1 commit into from
Apr 4, 2016

Conversation

matteofigus
Copy link
Member

  • Removed ace editor and replaced with good old textboxes (it is anyway kind of broken, loads a lot of extra javascript, doesn't add any value)
  • Added the Accept-Language field in order to test multi-lingual components

To test:

  • checkout the branch locally
  • go to a folder of components
  • load oc dev using local oc, example node ../oc/oc-cli.js dev . 3030
  • have fun

Can anyone have a look?
Thanks

@matteofigus matteofigus changed the title Removed editor + added Accept-Language box Removed ace editor + added Accept-Language box Apr 1, 2016
@jankowiakmaria
Copy link
Collaborator

lgtm, tested, merging

@jankowiakmaria jankowiakmaria merged commit 7108758 into master Apr 4, 2016
@jankowiakmaria jankowiakmaria deleted the ui-preview branch April 4, 2016 09:19
@matteofigus
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteofigus @jankowiakmaria