Ui improvements #293
Merged
Ui improvements #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaerre
reviewed
Sep 23, 2016
There was a problem hiding this comment.
there are no tests around the list-components.js components? (the server-side and the client-side one)
over to you @matteofigus
| } else if(mapped.state === 'experimental'){ | ||
| experimental++; | ||
| } | ||
|
|
There was a problem hiding this comment.
super minor one but what about this for readability?
if (mapped.state === 'deprecated') {
deprecated += 1;
}
if (mapped.state === 'experimental') {
experimental += 1;
}
There was a problem hiding this comment.
I removed this actually in favour of a more generic counts object that handles counts for any state. This should be also more flexible in case we add extra states in the future
| @@ -3,7 +3,7 @@ extends layout | |||
| mixin selectedCheckbox(name) | |||
| input(type="checkbox", name=name, checked) | |||
| .state | |||
| span(class="component-state-" + name)=name | |||
| span(class="component-state-" + name) #{name} (#{counts[name]}) | |||
|
|
||
| if(!!state){ | ||
| stateCounts[state] = stateCounts[state] || 0; | ||
| stateCounts[state]++; |
There was a problem hiding this comment.
I'd rather do stateCounts[state] += 1;
| @@ -30,11 +31,29 @@ oc.cmd.push(function(){ | |||
|
|
|||
| var show = matches && !isHidden; | |||
| selector[show ? 'removeClass' : 'addClass']('hide'); | |||
| if(!show){ | |||
| hidden++; | |||
mattiaerre
reviewed
Sep 23, 2016
|
|
||
| if(!!state){ | ||
| stateCounts[state] = stateCounts[state] || 0; | ||
| stateCounts[state] += 1; |
| return false; | ||
| }; | ||
|
|
||
| $('#filter-components').submit(componentsListChanged).keyup(componentsListChanged); | ||
| $('#filter-components input[type=checkbox').change(componentsListChanged); | ||
|
|
||
| if(!!q){ | ||
| $('.search').val(q); |
There was a problem hiding this comment.
nice one; you set the q value then you call componentsListChanged()
|
Yes go for it @mattiaerre |
|
Hi @matteofigus let us know when deployed 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for lots of small little improvements in the UI interface: