-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract package bugfix #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does my review make sense? @matteofigus 😄
expect(decompressStub.args[0][0]).to.eql({ | ||
dest: '/some-path/registry/temp/1478279453422/', | ||
src: '/some-path/registry/temp/1478279453422.tar.gz' | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind to swap the properties order? src
then dest
plz? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
} | ||
}, function(err, res){ | ||
error = err; | ||
response = res; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should assert against res
as it is what your component actually returns; maybe also add a test against the sad path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fixes #318
It turns out this was introduced with #316 - I added a unit test to ensure we are making the right call to the targz dependency.