Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract package bugfix #319

Merged
merged 3 commits into from
Nov 7, 2016
Merged

Extract package bugfix #319

merged 3 commits into from
Nov 7, 2016

Conversation

matteofigus
Copy link
Member

Fixes #318

It turns out this was introduced with #316 - I added a unit test to ensure we are making the right call to the targz dependency.

Copy link
Member

@mattiaerre mattiaerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does my review make sense? @matteofigus 😄

expect(decompressStub.args[0][0]).to.eql({
dest: '/some-path/registry/temp/1478279453422/',
src: '/some-path/registry/temp/1478279453422.tar.gz'
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind to swap the properties order? src then dest plz? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
}, function(err, res){
error = err;
response = res;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should assert against res as it is what your component actually returns; maybe also add a test against the sad path?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ArnoldZokas ArnoldZokas merged commit 7b18470 into master Nov 7, 2016
@matteofigus matteofigus deleted the targz-bugfix branch November 8, 2016 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants