Fix for #336 - Make S3 Key/Secret optional to allow support for "IAM … #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port for "IAM role based access to s3 from EC2"
|
I just published this to a new version and updated the docs: https://github.com/opentable/oc/wiki/Registry#registry-configuration Thanks for your help! |
|
Thanks Matteo for pushing out new revision. Will update to 0.33.29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336
Matteo, Here is the PR. I made Key/Secret pair optional. But also made sure that if either one is specified then other one is specified too. Added Test case as well.