[WIP][MLP-594] Adding history of published components to registry #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@federicomaffei I like this feature |
nickbalestra
reviewed
Apr 7, 2017
| module.exports = function(history) { | ||
| var result = []; | ||
|
|
||
| _.each(history.components, function(singleComponent, name) { |
There was a problem hiding this comment.
I guess histories could grows quite big in time.. then for loops instead of nested each will make a difference in perfs. We could also probably create a sorted array as we push them instead of having to loop through it again with sortBy. What you think?
There was a problem hiding this comment.
Agreed @nickbalestra, especially about the quick sort. That sort and reverse will not make it to the final version 👍
|
Closed this in favour of #467 (the first commits came from this branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge.