UI interface tests #455
Merged
UI interface tests #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pbazydlo
reviewed
Apr 10, 2017
| local: true, | ||
| path: path.resolve('test/fixtures/components'), | ||
| port: 3030, | ||
| baseUrl: 'http://localhost:3030/', |
There was a problem hiding this comment.
would you be able to test it with a path, ex. http://localhost:3030/v2/?
There was a problem hiding this comment.
I would be able to, not sure why should I?
The purpose of this tests is mostly ensure that we have a kind of smoke test for when we change the registry so that the UI doesn't break. Tests for testing the "prefix" parameter (what would be like a /v2/ segment - are already there on a unit level.
There was a problem hiding this comment.
I've recently encountered a bug where /v2/ was being removed when browsing components. But if it's covered elsewhere then it doesn't matter
There was a problem hiding this comment.
Ok @pbazydlo, so can you approve?
pbazydlo
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.