Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error before exiting #457

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Log error before exiting #457

merged 1 commit into from
Apr 10, 2017

Conversation

matteofigus
Copy link
Member

As reported by @pbazydlo

FYI, callback then does a synchronous process.exit(1): https://github.com/opentable/oc/blob/master/src/cli/wrap-cli-callback.js#L12

@matteofigus matteofigus merged commit 77fc9e7 into master Apr 10, 2017
@matteofigus matteofigus deleted the oc-dev-port branch April 10, 2017 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants