[OC-49] Templates #525
Merged
[OC-49] Templates #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
force-pushed
the
templates
branch
2 times, most recently
from
d7c1184
to
8f5f03d
Compare
nickbalestra
force-pushed
the
templates
branch
3 times, most recently
from
9d0151d
to
69d3cf5
Compare
|
Please squash this on merge |
matteofigus
requested changes
Jul 20, 2017
src/resources/index.js
Outdated
| @@ -121,7 +121,7 @@ module.exports = { | |||
| TEMPLATE_TYPE_NOT_VALID: | |||
| 'the template is not valid. Allowed values are handlebars and jade', | |||
| TEMPLATE_DEP_MISSING: | |||
| 'Template dependency missing. Run "$npm install --save {0}" to fix it.' | |||
| 'Template dependency missing. To fix it run:\n\ncd {0} && npm install --save-dev {1}-compiler\n\n' | |||
There was a problem hiding this comment.
Maybe we can just do npm install --save-dev {1}-compiler --prefix {0}. Perhaps reverting 0 with 1 for simplicity :D
| before(() => { | ||
| const readJsonStub = sinon.stub(); | ||
|
|
||
| readJsonStub.onFirstCall().returns({ | ||
| oc: baseOcFragment('oc-template-react'), | ||
| dependencies: { 'oc-template-react': '1.2.3'} | ||
| devDependencies: { 'oc-template-react-compiler': '1.2.3' } |
There was a problem hiding this comment.
can we add here eslint as devDependency too? So we can test that is not added to the ones that need to be installed
| it('should minify static resources', () => { | ||
| expect(packageStaticFilesStub.args[0][0].minify).to.eql(false); | ||
| }); | ||
| describe('when component is not valid', () => { |
There was a problem hiding this comment.
When component parameters rename?
| @@ -17,7 +17,7 @@ describe('utils : require-template', () => { | |||
|
|
|||
| scenarios.forEach(scenario => { | |||
| it(scenario.name, () => { | |||
There was a problem hiding this comment.
Let's add another little scenario for compiler true|false?
matteofigus
approved these changes
Jul 20, 2017
added 15 commits
July 21, 2017 10:29
added 21 commits
July 21, 2017 10:29
… -compiler modules
…f not already avail
|
Run it against our production sites/components and everything seemed to work correctly. |
This was referenced Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature branch ready to be merged to master after
CC @mattiaerre @matteofigus