[OC-140] Declarative templates initialisation on a registry level #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
changed the title
matteofigus
requested changes
Aug 30, 2017
| }); | ||
|
|
||
| return { | ||
| templates, |
There was a problem hiding this comment.
let's remove templates as we don't need it anymore
src/registry/domain/repository.js
Outdated
| const S3 = require('./s3'); | ||
| const settings = require('../../resources/settings'); | ||
| const strings = require('../../resources'); | ||
| const validator = require('./validators'); | ||
| const versionHandler = require('./version-handler'); | ||
| const registerTemplates = require('./register-templates'); | ||
|
|
| describe('registry : domain : register-templates', () => { | ||
| const registerTemplates = require('../../src/registry/domain/register-templates.js'); | ||
|
|
||
| describe('when templates get registerd without additional templates', () => { |
matteofigus
approved these changes
Aug 30, 2017
|
Merged. @nickbalestra can you publish and update the wiki? Cheers. |
|
@matteofigus done (0.41.0 out and wiki updated) |
This was referenced Sep 4, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates declaration is now more explicit when configuring the registry (same API as per the node client):