[DX-185] Refactoring #681
Merged
[DX-185] Refactoring #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
reviewed
Oct 3, 2017
| if (code !== 0) { | ||
| return callback('template type not valid'); | ||
| npm.installDependency(npmOptions, (err, result) => { | ||
| const errorMessage = 'template type not valid'; |
There was a problem hiding this comment.
Note: In the future we might want to improve those errors, I found that as we use the same error in different point make it quite hard to debug.
nickbalestra
approved these changes
Oct 3, 2017
matteofigus
commented
Oct 5, 2017
|
|
||
| const installedCompiler = tryRequire(result.dest); | ||
|
|
||
| if (!isValidTemplate(compiler, { compiler: true })) { |
There was a problem hiding this comment.
Ah! that should have been isValidTemplate(installedCompiler... instead! Bugfix coming in another PR: #694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of a job of cleaning up all the npm stuff.
The idea is to progressively move all the interactions to npm to an independent module for better modularity and less coupling.