Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added author to components list view and author filter #829

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

jankowiakmaria
Copy link
Collaborator

I've added a "Filter by component author" next to "Filter by component name".

I've introduced flexbox as it was easier for me to sort out the styling.

Test plan
Screenshots provided in the issue.

Closing issues
closes #824

Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jankowiakmaria - good work!

I tried to run it locally, the only issue I see seems related to the Dependencies & History tabs' CSS.
Example:
screen shot 2018-02-08 at 09 26 46

Can you look into it?
Thanks

@jankowiakmaria
Copy link
Collaborator Author

Sure, will do. I guess I missed this view.

@jankowiakmaria
Copy link
Collaborator Author

@matteofigus I've updated PR.

Screenshots:

  • components
    components
  • history
    history
  • available dependencies
    available_dependencies

@jankowiakmaria jankowiakmaria removed the wip label Feb 9, 2018
@matteofigus matteofigus merged commit b752b2e into master Feb 9, 2018
@matteofigus matteofigus deleted the AuthorFilter branch February 9, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author filter in registry page
2 participants