[DX-497] OC Clean #872
Merged
[DX-497] OC Clean #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
commented
May 4, 2018
| @@ -1,5 +1,7 @@ | |||
| 'use strict'; | |||
| const colors = require('colors/safe'); | |||
| const { green, yellow } = require('colors/safe'); | |||
|
|
|||
There was a problem hiding this comment.
I moved things around in this file to optimise readability, definitely doing another separate PR afterwards to reorganise this stuff
matteofigus
commented
May 4, 2018
| dev: { | ||
| cmd: 'dev <dirPath> [port] [baseUrl]', | ||
| example: { | ||
| cmd: | ||
| '$0 dev ../all-components 3001 127.0.0.1:3001 --fallbackRegistryUrl=http://anotherhost:anotherport/' | ||
| }, | ||
| description: | ||
| 'Runs a local oc test registry in order to develop and test components', | ||
| 'Run a local oc test registry in order to develop and test components', |
There was a problem hiding this comment.
Took inspiration from lerna here, all the actions are intended as 2nd person rather than 3rd person intending the action is done by the user not the CLI really :)
matteofigus
commented
May 4, 2018
| @@ -43,7 +57,7 @@ module.exports = { | |||
| default: '' | |||
| } | |||
| }, | |||
| usage: 'Usage: $0 dev <dirName> [port] [baseUrl] [options]' | |||
| usage: 'Usage: $0 dev <dirPath> [port] [baseUrl] [options]' | |||
There was a problem hiding this comment.
I updated this example to reflect the naming we use everywhere else
nickbalestra
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an handy oc clean command, pretty useful with monorepos of OCs that now contain templates and subdeps. The functionality is pretty similar to lerna's clean.