Fix oc-cli breaking on Windows when modifying files #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
Thanks! LGTM but I also would like @Kimtaro to give this a quick look if possible! 👍
|
👍 |
|
I am merging this to unblock you as I imagine the frustration. Let's review with Kim afterwards or in case of issues. |
|
@matteofigus Specifically the regex? 😃 Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898
Test plan (required)
Add unit test to cover the issue. Tested the fix worked by creating component with
oc init, runningoc devand modifying component code.Closing issues
closes #898