-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding snappi vlan traffic testcase (#5) #117
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments about test cases being able to run with SW or HW traffic generators, and avoiding vendor-specific settings if possible
57fb981
to
c367f39
Compare
@selldinesh , as a common practice, a test should contain both setup and teardown. It make sense to split setup and teardown into separate test-cases either in case the same basic configuration should be used by the number of tests (by test suite) or when we want to test some object removal as a separate scenario. In such case it's better to group the tests into the test class. E.g., SAI-Challenger/tests/ut/test_acl_ut.py Line 21 in 53b32cc
Please correct me if I'm wrong but this PR contains neither of these two. It's more like a standalone VLAN scenario with traffic. Something very similar to SAI-Challenger/tests/test_l2_basic.py Line 20 in 53b32cc
So, I'd suggest to make it as a single TC. Also, please make sure the teardown procedure reverts the configuration to what was right before TC execution. |
tests/snappi/test_vlan_traffic.py
Outdated
npu.objects_discovery() | ||
|
||
|
||
def test_l2_untagged_vlan_traffic(npu, dataplane): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this TC will we skipped in case ((pytest is executed without specifying the test file of or tests wildcard) and dataplane is not snappi).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the skip all fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned above, please make sure that the traffic related part of TC will be skipped in case dataplane type is not snappi
.
if npu.run_traffic and dataplane.config["type"] == "snappi":
# Traffic check
052ea3e
to
eb6e395
Compare
d77a660
to
6081480
Compare
* adding snappi folder with vlan case Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * formatted Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> --------- Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
adding data capture for tagged traffic Signed-off-by: Dinesh Kumar Sellappan <dinesh.sellappan@keysight.com>
a6b1506
to
90ae887
Compare
This PR contains the test cases for running l2 traffic using snappi and SAI api with data driven model