Add L2 test for LAG hash seed #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu>
yuriilisovskyi
requested review from
andriy-kokhan and
anton7811
as code owners
tests/test_l2_basic.py
Outdated
| npu.remove_vlan_member(npu.default_vlan_oid, npu.dot1q_bp_oids[4]) | ||
|
|
||
| # Create LAG | ||
| lag_oid = npu.create(SaiObjType.LAG, []) |
There was a problem hiding this comment.
Hm.. should we make def create(..., attrs=[], .. )? what do you thing?
There was a problem hiding this comment.
Added a "draft" version of create_lag API with attrs=[] by default which simplifies the LAG creation and management. Please review
yuriilisovskyi
force-pushed
the
sai_l2_ft
branch
2 times, most recently
from
65b2a21
to
32251b3
Compare
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu>
yuriilisovskyi
force-pushed
the
sai_l2_ft
branch
from
32251b3
to
c3b9e54
Compare
tests/test_l2_basic.py
Outdated
|
|
||
| pkt = simple_tcp_packet(eth_dst=mac, | ||
| eth_src=src_mac, | ||
| ip_dst=ip_dst, |
There was a problem hiding this comment.
looks like a mix of spaces an tabs
tests/test_l2_basic.py
Outdated
| ip_dst=ip_dst, | ||
| ip_src=ip_src, | ||
| tcp_sport=sport, | ||
| tcp_dport=dport, |
There was a problem hiding this comment.
looks like a mix of spaces an tabs
common/sai_npu.py
Outdated
| @@ -203,6 +205,18 @@ def dataplane_pkt_listen(self): | |||
| self.hostif_dataplane.setPortMap(self.port_map) | |||
| self.port_map = None | |||
|
|
|||
| def create_lag(self, lag_attrs=[], lag_members=None): | |||
There was a problem hiding this comment.
three issues I see here:
- the method creates lag members implicitly
- no way to get lag/lag_mbr oids but through npu.lag which is not obvious
- no remove API...
lets do not do this for now
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu>
yuriilisovskyi
force-pushed
the
sai_l2_ft
branch
from
3bec540
to
fcd18ed
Compare
andriy-kokhan
approved these changes
Aug 26, 2023
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
added a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Oct 5, 2023
* Add LAG hash seed test-case (opencomputeproject#184) Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * adding additional create remove cases (#14) Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * removing switch tunnel Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * resolving PR comments and merge conflict Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * resolving precommit checks Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * reverting sai and l2 basic Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Fixed u8/u16 and range Thrift conversions (opencomputeproject#188) Signed-off-by: Andriy Kokhan <andriy.kokhan@gmail.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Updated PTF use-case. Enabled PTF TCs run from CI/CD (opencomputeproject#189) Signed-off-by: Andriy Kokhan <andriy.kokhan@gmail.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Fix oper status check (opencomputeproject#192) Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Added support for string SAI_NULL_OBJECT_ID for Thrift RPC (opencomputeproject#194) Signed-off-by: Vinod Kumar <vikumar7ks@gmail.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Remove unnecessary adding BPs to default VLAN on init (opencomputeproject#193) Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Adding new DASH TCs for create, set and remove API (opencomputeproject#195) Signed-off-by: Vinod Kumar <vikumar7ks@gmail.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Adding new DASH TCs for create, set and remove API 2nd set (opencomputeproject#197) Signed-off-by: Vinod Kumar <vikumar7ks@gmail.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Fixed set_sku_mode() (opencomputeproject#198) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Added FDB basic UTs (opencomputeproject#199) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Added LAG basic UTs (opencomputeproject#200) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Added FDB flush UTs (opencomputeproject#201) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * [CI/CD] Fixed checks what Docker images have to be rebuild (opencomputeproject#206) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Updated to SAI v1.13+ (opencomputeproject#205) * Added nlohmann-json3-dev as new sairedis dependency * Extended list of unsupported types in get_by_type() --------- Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Fixed pytest warnings (opencomputeproject#207) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Refactored Redis RPC I/O failure processing (opencomputeproject#208) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Removed obsoleted exec option. Please use "--testbed" instead (opencomputeproject#209) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Add generic SAI Thrift server (opencomputeproject#203) Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * Fixed "--traffic" option behavior (opencomputeproject#210) Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * line ending change Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> * adding additional tofino vs pass cases * adding skip all * pytest --------- Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com> Signed-off-by: Andriy Kokhan <andriy.kokhan@gmail.com> Signed-off-by: Vinod Kumar <vikumar7ks@gmail.com> Signed-off-by: Andriy Kokhan <andriy.kokhan@plvision.eu> Co-authored-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Co-authored-by: Andriy Kokhan <andriy.kokhan@gmail.com> Co-authored-by: vikumarks <119973184+vikumarks@users.noreply.github.com> Co-authored-by: Andriy Kokhan <andriy.kokhan@plvision.eu>
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/SAI-Challenger
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Yurii Lisovskyi <yurii.lisovskyi@plvision.eu> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.