Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test Cases for Get, Set on the Api Attributes #196

Closed
wants to merge 0 commits into from

Conversation

selldinesh
Copy link
Contributor

Description of PR
Summary: Contributing SAI test cases that qualifies the SAI apis. This PR consists of test cases that does Get and Set operation on the API.
The cases have been validated to be passing on Edgecore DUT with Broadcom asic

SAI-Challenger Version: : 40e09a6

@andriy-kokhan
Copy link
Contributor

I'm wondering what has happened with similar PRs opened previously? I'm referring to #191, #185. Significant part of these changes was already reviewed as a part of 185/191. I believe the iterative process will be more efficient.

@selldinesh selldinesh force-pushed the pr_new_get_set branch 3 times, most recently from e586245 to 613c44c Compare October 16, 2023 17:34
@andriy-kokhan
Copy link
Contributor

Looks like your branch should be rebased to the latest community main branch

@selldinesh
Copy link
Contributor Author

@andriy-kokhan is it possible to reopen this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants