Skip to content

Commit

Permalink
updated the document based on community input
Browse files Browse the repository at this point in the history
Signed-off-by: Shahzad Iqbal <shahzad.iqbal@microsoft.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
  • Loading branch information
siqbal1986 committed Sep 30, 2024
1 parent 5b0cb2f commit a753d25
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions doc/QOS/SAI-Proposal-Egress-DSCP.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ The overall behavior can be segregated into three sections of the pipeline. Ingr

# Model for Egress Behavior #
The DSCP value set by various components on the egress side of the ASIC pipeline shall have the following precedence in descending order. This precedence shall apply to packets in the egress pipeline and shall override any other DSCP value set by the Ingress stage.
**However This precedence would be overriden if the platform provides the necessary SAI capibility API for Egress precedence check. This SAI API currently does not exist but would be added at a later date. For further details, please refer to the Community feedback section of this document.**

1. Egress ACL.

Expand All @@ -56,3 +57,17 @@ These following is a logical diagram which shows how the DSCP value of a packet

<img src="../figures/egress_dscp_change_precedence.png" width="1200">


## Community Feedback ##
After discussion with the SAI community the following feedback was recieved.

1. The proposal should be enhanced to cover for both Ingress and Egress stages of pipelines.

2. A SAI attribute should be devised to query the precedence behaviour set by the platform.

The following issues have been created to track these additional enhancements.

https://github.com/opencomputeproject/SAI/issues/2080 Request for SAI Ingress DSCP/TC precedence behavior document.

https://github.com/opencomputeproject/SAI/issues/2081 Request for SAI capability check to determine the Ingress/Egress DSCP/TC action precedence supported by the ASIC

0 comments on commit a753d25

Please sign in to comment.