Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRBS RX State Data Type #1179

Merged
merged 8 commits into from
Mar 17, 2021
Merged

PRBS RX State Data Type #1179

merged 8 commits into from
Mar 17, 2021

Conversation

JaiOCP
Copy link
Contributor

@JaiOCP JaiOCP commented Jan 6, 2021

Read Only attribute for getting Rx error count

Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
@lguohan lguohan changed the title PRBX Rx Error Count PRBS Rx Error Count Jan 14, 2021
inc/saiport.h Outdated Show resolved Hide resolved
@rlhui
Copy link
Collaborator

rlhui commented Jan 20, 2021

@marian-pritsak - would you like to review this for MLNX?

Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
inc/saiport.h Outdated Show resolved Hide resolved
@JaiOCP JaiOCP changed the title PRBS Rx Error Count Flex State Complex Data Type Jan 28, 2021
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
inc/saitypes.h Outdated Show resolved Hide resolved
@rlhui
Copy link
Collaborator

rlhui commented Mar 4, 2021

@rck-innovium please help review/approve, thanks.

inc/saitypes.h Outdated Show resolved Hide resolved
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
@JaiOCP JaiOCP changed the title Flex State Complex Data Type PRBS RX State Data Type Mar 4, 2021
inc/saiport.h Show resolved Hide resolved
Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
@JaiOCP
Copy link
Contributor Author

JaiOCP commented Mar 9, 2021

@rlhui Please merge

inc/saiport.h Outdated Show resolved Hide resolved
Copy link
Contributor

@rck-innovium rck-innovium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jai,

We need the below understanding to be documented:


There are multiple SAI attributes/stat-id (viz., SAI_PORT_ATTR_PRBS_RX_STATE, SAI_PORT_ATTR_PRBS_RX_STATUS, SAI_PORT_PRBS_RX_STATUS_LOCK_WITH_ERRORS) for PORT PRBS status. It depends on the underlying ASIC as to which of these attributes are applicable. The suggestion was that the application would first query SAI_PORT_ATTR_PRBS_RX_STATE. If the SAI implementation returns that the attribute is unsupported, the application would then fallback to query the existing SAI_PORT_ATTR_PRBS_RX_STATUS and SAI_PORT_PRBS_RX_STATUS_LOCK_WITH_ERRORS.


Signed-off-by: Jai Kumar <jai.kumar@broadcom.com>
@rlhui
Copy link
Collaborator

rlhui commented Mar 16, 2021

Hi Jai,

We need the below understanding to be documented:

There are multiple SAI attributes/stat-id (viz., SAI_PORT_ATTR_PRBS_RX_STATE, SAI_PORT_ATTR_PRBS_RX_STATUS, SAI_PORT_PRBS_RX_STATUS_LOCK_WITH_ERRORS) for PORT PRBS status. It depends on the underlying ASIC as to which of these attributes are applicable. The suggestion was that the application would first query SAI_PORT_ATTR_PRBS_RX_STATE. If the SAI implementation returns that the attribute is unsupported, the application would then fallback to query the existing SAI_PORT_ATTR_PRBS_RX_STATUS and SAI_PORT_PRBS_RX_STATUS_LOCK_WITH_ERRORS.

@rck-innovium - do you agree/approve this PR?

@rck-innovium
Copy link
Contributor

@rck-innovium - do you agree/approve this PR?

Yes. Jai has said that he will document the NOS expectation in the release nots.

@rlhui rlhui merged commit 13e5cd6 into opencomputeproject:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants