saineighbor.h: Updated SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_INDEX and deprecated SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_IMPOSE_INDEX #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_INDEX Signed-off-by: SarathBug <sarath.gadagottu@broadcom.com>
kcudnik
requested changes
Mar 9, 2021
|
please relax saisanitycheck.c condition on 1178, add case for this scenario |
…ated SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_INDEX Signed-off-by: SarathBug <sarath.gadagottu@broadcom.com>
|
@eswaranb , @skeesara-nokia - please review, thanks. |
kcudnik
approved these changes
Mar 10, 2021
eswaranb
approved these changes
Mar 10, 2021
|
Can this be committed if there are no other comments? |
skeesara-nokia
approved these changes
Mar 17, 2021
|
the PR title does not match the change - "SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_INDEX " was repeated? |
rlhui
requested changes
Mar 18, 2021
SarathBug
changed the title
@rlhui, Thanks for the comment. Corrected it. |
rlhui
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1165
Signed-off-by: SarathBug sarath.gadagottu@broadcom.com