Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mdio access type (clause 45/clause 22) attribute #1493

Closed
wants to merge 2 commits into from
Closed

Add mdio access type (clause 45/clause 22) attribute #1493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bb983d
Add mdio access type (clause 45/clause 22) attribute
jiahua-wang Jun 13, 2022
8e395a2
Add mdio access type attribute and enum type
jiahua-wang Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions inc/saiswitch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2776,6 +2776,20 @@ typedef enum _sai_switch_attr_t
*/
SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT,

/**
* @brief Enable/disable Clause 22 MDIO access
*
* set mdio access type (clause 45 or clause 22) before calling sai_switch_mdio_read_fn and sai_switch_mdio_write_fn
*
* FALSE - sai_switch_mdio_read_fn and sai_switch_mdio_write_fn use clasue 45 mdio access.
* TRUE - sai_switch_mdio_read_fn and sai_switch_mdio_write_fn use clasue 22 mdio access.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could there be other clauses more in the future ? maybe this should be enum?, i think enum would be better here, since bool value should be used for something that is enabled or not, and here you have explicit types 22 and 45 to set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDIO was originally defined in Clause 22 of IEEE RFC802.3. Clause 45 of the 802.3ae specification provided the ability to access 65,536 registers in 32 different devices on 32 different ports. 802.3ae is 20 years old. There is no new MDIO access mode in the last 20 years. MDIO frame format starts with 32 bits of logical 1 preamble and 2 bits of start of frame. The start of frame is 01 for clause 22 and 00 for clause 45. If the first bit of the start frame has to be logical 0, then no new MDIO frame format will be possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, but it still would make sense to make it as enum, like for example you would have ipv4 and ipv6, it's better specify it as enum rather then bool, maybe lets ask community on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to attribute SAI_SWITCH_ATTR_MDIO_ACCESS_TYPE and enum sai_switch_mdio_clause_t

*
* @type bool
* @flags CREATE_AND_SET
* @default false
*/
SAI_SWITCH_ATTR_MDIO_CLAUSE_22,

/**
* @brief End of attributes
*/
Expand Down