Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER Support #1993

Merged
merged 2 commits into from
Aug 5, 2024
Merged

SER Support #1993

merged 2 commits into from
Aug 5, 2024

Conversation

JaiOCP
Copy link
Contributor

@JaiOCP JaiOCP commented Apr 15, 2024

SER Support is added on top of base infra introduced by
#1777

Previous PR is closed as the branch was very old and couldn't reconcile the older commits with enum shifts.
#1979
#1982

Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
@JaiOCP
Copy link
Contributor Author

JaiOCP commented Apr 15, 2024

@kcudnik Thrift compiler toolchain is causing the build to fail. Please take a look

@kcudnik
Copy link
Collaborator

kcudnik commented Apr 15, 2024

yes, we are aware, not sure yet how to fix that

@rlhui
Copy link
Collaborator

rlhui commented Apr 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui
Copy link
Collaborator

rlhui commented Apr 17, 2024

@kcudnik Thrift compiler toolchain is causing the build to fail. Please take a look

@JaiOCP it's now fixed. But this PR is failing metadata check:

updating sai_switch_health_data_t since member count changed from 1 to 2
processing commit bffc28f
ERROR: FATAL: sai_switch_health_data_t members were removed on commit bffc28f, NOT ALLOWED!
make: *** [Makefile:91: all] Error 1

@JaiOCP
Copy link
Contributor Author

JaiOCP commented Apr 17, 2024 via email

@kcudnik
Copy link
Collaborator

kcudnik commented Apr 17, 2024

i pulled your PR, and it passes locally on my machine

@kcudnik
Copy link
Collaborator

kcudnik commented Apr 17, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Apr 17, 2024

your commit is too far behind,

* ca6b08f (origin/master, origin/HEAD) Update sai version to v1.14.0 (#1991)
* 446b2b7 Upgrade the PR checker's slave container to Bullseye (#1994)
* cd249d6 Modified the test script to match ACL match fields which should be configured to match l4 src and dst port (#1960)
* bffc28f Modified the test file to fix Invalid IP prefix format error while creatimg route entry (#1959)
| * 3e4d429 (1993) SER Support
|/
* d967d23 Add attribute to query the capability of Pre-Ingress ACL stage (#1984)

you will need to rebase locally to master, and then force push to PR, then it will pass

@tjchadaga
Copy link
Collaborator

Approving based on prior approvals in #1982 and this comment -#1982 (comment) for backward compatibility.

@tjchadaga tjchadaga merged commit a8743f8 into opencomputeproject:master Aug 5, 2024
3 checks passed
siqbal1986 pushed a commit to siqbal1986/SAI that referenced this pull request Sep 30, 2024
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
erohsik pushed a commit to erohsik/SAI that referenced this pull request Nov 7, 2024
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants