-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SER Support #1993
SER Support #1993
Conversation
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
@kcudnik Thrift compiler toolchain is causing the build to fail. Please take a look |
yes, we are aware, not sure yet how to fix that |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@JaiOCP it's now fixed. But this PR is failing metadata check: updating sai_switch_health_data_t since member count changed from 1 to 2 |
I have created a new PR. Could it be something to do with adding exception?On Apr 16, 2024, at 7:52 PM, Rita Hui ***@***.***> wrote:
@kcudnik Thrift compiler toolchain is causing the build to fail. Please take a look
@JaiOCP it's now fixed. But this PR is failing metadata check:
updating sai_switch_health_data_t since member count changed from 1 to 2
processing commit bffc28f
ERROR: FATAL: sai_switch_health_data_t members were removed on commit bffc28f, NOT ALLOWED!
make: *** [Makefile:91: all] Error 1
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
|
i pulled your PR, and it passes locally on my machine |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
your commit is too far behind,
you will need to rebase locally to master, and then force push to PR, then it will pass |
Approving based on prior approvals in #1982 and this comment -#1982 (comment) for backward compatibility. |
This reverts commit a8743f8.
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
SER Support is added on top of base infra introduced by
#1777
Previous PR is closed as the branch was very old and couldn't reconcile the older commits with enum shifts.
#1979
#1982