Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made SAI_BUFFER_POOL_ATTR_TH_MODE as create only #2

Closed
wants to merge 1 commit into from

Conversation

dgsudharsan
Copy link
Contributor

We have the below attributes in buffer profile

/** dynamic threshold for the shared usage [sai_int8_t]
 * The threshold is set to the 2^n of available buffer of the pool.
 * Mandatory when SAI_BUFFER_POOL_TH_MODE = SAI_BUFFER_THRESHOLD_MODE_DYNAMIC
 * (CREATE_AND_SET). */
SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH,

/** static threshold for the shared usage in bytes [sai_uint32_t]
 * Mandatory when SAI_BUFFER_POOL_TH_MODE = SAI_BUFFER_THRESHOLD_MODE_STATIC
 * (CREATE_AND_SET) */
SAI_BUFFER_PROFILE_ATTR_SHARED_STATIC_TH,

In buffer pool attribute
/** shared threshold mode for the buffer pool sai_buffer_threadhold_mode_t (CREATE_AND_SET)
* (default to SAI_BUFFER_POOL_DYNAMIC_TH) */
SAI_BUFFER_POOL_ATTR_TH_MODE,

If we had created some buffer profiles and associated them to a pool changing the pool th_mode should be restricted since we already would have set the profile thresholds values based on initial pool threshold modifying them would cause problems. Also there are no use case to modify threshold mode dynamically and hence having it as create only.

@lguohan
Copy link
Collaborator

lguohan commented Oct 8, 2015

merged, thanks.

@lguohan lguohan closed this Oct 8, 2015
@dgsudharsan dgsudharsan deleted the dgqos1 branch January 8, 2016 04:52
IGordynskyi pushed a commit to IGordynskyi/SAI that referenced this pull request Sep 23, 2016
Fixed ACL table creation using boolean  attributes which indicate whi…
engdorm added a commit to engdorm/SAI that referenced this pull request Nov 10, 2016
zhiyuan0112 pushed a commit to zhiyuan0112/SAI that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants