Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Next Hop Type and allow Next Hop to be an IPMC Group Member #2041

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

mholankar
Copy link
Contributor

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
@mholankar
Copy link
Contributor Author

@mikeberesford for review

@mholankar
Copy link
Contributor Author

@JaiOCP @kcudnik

@JaiOCP
Copy link
Contributor

JaiOCP commented Jul 8, 2024

Can you please convert the pdf file to .md format and check it in for review.

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
@mholankar
@mholankar
Copy link
Contributor Author

@JaiOCP added the doc

inc/saiipmcgroup.h Outdated Show resolved Hide resolved
@mholankar
Copy link
Contributor Author

@tjchadaga can this PR be discussed in tomorrow's meeting?

@tjchadaga
Copy link
Collaborator

@tjchadaga can this PR be discussed in tomorrow's meeting?

@mholankar - sure, this PR discussion is now scheduled for 7/18

inc/saiipmcgroup.h Outdated Show resolved Hide resolved
Took care of review comments

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
@mholankar
@mholankar
Copy link
Contributor Author

Took care of the review comments for this PR. @tjchadaga @JaiOCP @kcudnik

@tjchadaga
Copy link
Collaborator

@rck-innovium - could you please help sign off on this as well?

@mholankar mholankar requested a review from JaiOCP July 22, 2024 21:53
@mholankar
Copy link
Contributor Author

@tjchadaga can this PR be merged?

@tjchadaga tjchadaga requested a review from kcudnik August 1, 2024 17:09
@tjchadaga
Copy link
Collaborator

@tjchadaga can this PR be merged?

Need one more vendor sign-off. @rck-innovium - would you be able to review and sign-off on this?

doc/IP-Multicast/MulticastNextHopRewrite.md Outdated Show resolved Hide resolved
doc/IP-Multicast/MulticastNextHopRewrite.md Outdated Show resolved Hide resolved
Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
@mholankar mholankar requested a review from rck-innovium August 3, 2024 00:37
● SAI_ROUTER_INTERFACE_ATTR_TYPE=SAI_ROUTER_INTERFACE_TYPE_

```
PORT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAI_ROUTER_INTERFACE_ATTR_TYPE=SAI_ROUTER_INTERFACE_TYPE_PORT


### pipeline is very similar to Unicast Forwarding. The reference pipeline is

### fromUnicastForwarding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pl remove '###' for lines 15 to 19.

@tjchadaga tjchadaga merged commit c907595 into opencomputeproject:master Aug 5, 2024
3 checks passed
siqbal1986 pushed a commit to siqbal1986/SAI that referenced this pull request Sep 30, 2024
…pencomputeproject#2041)

* Add new Next Hop Type and allow Next Hop to be an IPMC Group Member

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
erohsik pushed a commit to erohsik/SAI that referenced this pull request Nov 7, 2024
…pencomputeproject#2041)

* Add new Next Hop Type and allow Next Hop to be an IPMC Group Member

Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants