-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Next Hop Type and allow Next Hop to be an IPMC Group Member #2041
Add new Next Hop Type and allow Next Hop to be an IPMC Group Member #2041
Conversation
Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
b74a411
to
07224cf
Compare
@mikeberesford for review |
Can you please convert the pdf file to .md format and check it in for review. |
Signed-off-by: Manali Holankar <manali.holankar@gmail.com> @mholankar
@JaiOCP added the doc |
@tjchadaga can this PR be discussed in tomorrow's meeting? |
@mholankar - sure, this PR discussion is now scheduled for 7/18 |
Took care of review comments Signed-off-by: Manali Holankar <manali.holankar@gmail.com> @mholankar
57b6b51
to
24b23a7
Compare
Took care of the review comments for this PR. @tjchadaga @JaiOCP @kcudnik |
@rck-innovium - could you please help sign off on this as well? |
@tjchadaga can this PR be merged? |
Need one more vendor sign-off. @rck-innovium - would you be able to review and sign-off on this? |
Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
● SAI_ROUTER_INTERFACE_ATTR_TYPE=SAI_ROUTER_INTERFACE_TYPE_ | ||
|
||
``` | ||
PORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SAI_ROUTER_INTERFACE_ATTR_TYPE=SAI_ROUTER_INTERFACE_TYPE_PORT
|
||
### pipeline is very similar to Unicast Forwarding. The reference pipeline is | ||
|
||
### fromUnicastForwarding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pl remove '###' for lines 15 to 19.
…pencomputeproject#2041) * Add new Next Hop Type and allow Next Hop to be an IPMC Group Member Signed-off-by: Manali Holankar <manali.holankar@gmail.com> Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
…pencomputeproject#2041) * Add new Next Hop Type and allow Next Hop to be an IPMC Group Member Signed-off-by: Manali Holankar <manali.holankar@gmail.com>
[External] SAI _ Multicast Next Hop Disable L3 Rewrites.pdf