Update DASH SAI API comments #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: r12f <r12f.code@gmail.com>
r12f
force-pushed
the
user/r12f/dash-comments
branch
from
fbf5fa0 to
2bb3f75
Compare
Signed-off-by: r12f <r12f.code@gmail.com>
Pterosaur
approved these changes
Jul 12, 2024
|
Hi @prsunny , could you please help review and merge this PR? |
|
lgtm. This brings these SAI APIs in sync with the DASH generated APIs |
marian-pritsak
approved these changes
Jul 13, 2024
kcudnik
reviewed
Jul 14, 2024
Signed-off-by: r12f <r12f.code@gmail.com>
siqbal1986
pushed a commit
to siqbal1986/SAI
that referenced
this pull request
Sep 30, 2024
This PR is intended to update the current comments of DASH SAI APIs. Previously, all DASH SAI API comments are generated from P4 code using very simple rule, such as all words to upper case to pass the SAI checks. Now, we switched to python for better comment generation, which makes the comment more meaningful and readable. Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
erohsik
pushed a commit
to erohsik/SAI
that referenced
this pull request
Nov 7, 2024
This PR is intended to update the current comments of DASH SAI APIs. Previously, all DASH SAI API comments are generated from P4 code using very simple rule, such as all words to upper case to pass the SAI checks. Now, we switched to python for better comment generation, which makes the comment more meaningful and readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to update the current comments of DASH SAI APIs.
Previously, all DASH SAI API comments are generated from P4 code using very simple rule, such as all words to upper case to pass the SAI checks. Now, we switched to python for better comment generation, which makes the comment more meaningful and readable.