Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty dir for mounting USB device #718

Closed
wants to merge 1 commit into from

Conversation

pichuang
Copy link
Contributor

The directory can avoid user mount over issue.
It would be more clear when user want to mount USB.

Signed-off-by: Phil Huang phil_huang@edge-core.com

@pichuang
Copy link
Contributor Author

pichuang commented Mar 20, 2018

I have met many customers mount USB on /mnt. It cause onie-nos-installer can't find /mnt/onie-boot because personal issue.

@pichuang
Copy link
Contributor Author

Refer the real case - sonic-net/SONiC#161

@cbrune
Copy link
Contributor

cbrune commented Mar 20, 2018

This seems like a fine idea. I would like to see the patch do this for all CPU architectures, not just x86.

To do that I would define the variable in rootconf/default/lib/onie/function and perform the mkdir in rootconf/default/etc/init.d/makedev.sh.

Follow the model of the ONIE_RUN_DIR variable.

The directory can avoid user mount over issue.
It would be more clear when user want to mount USB.

Signed-off-by: Phil Huang <phil_huang@edge-core.com>
@pichuang
Copy link
Contributor Author

@cbrune Thanks for your suggestion. How about the latest PR?

@cbrune
Copy link
Contributor

cbrune commented Mar 20, 2018

Looks good, thanks!
Pushed to master:

  • a2bd122 Add empty dir for mounting USB device

@cbrune cbrune closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants