Update the proto comments to make it clear idevid is optional

openconfig · Sep 17, 2024 · 5eef834 · 5eef834
1 parent 560ec35
commit 5eef834
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/proto/tpm_attestz.proto b/proto/tpm_attestz.proto
@@ -76,8 +76,8 @@ message AttestResponse {
   bytes quote_signature = 5;
 
   // [Optional] PEM-encoded owner initial DevID certificate signed by the
-  // switch owner/administrator CA. This field should only be populated for
-  // standby/secondary control card.
+  // switch owner/administrator CA. This field may only be populated for
+  // the standby/secondary control card.
   string oidevid_cert = 6;
 }
 

diff --git a/proto/tpm_enrollz.proto b/proto/tpm_enrollz.proto
@@ -56,8 +56,9 @@ message RotateOIakCertRequest {
   // switch owner/administrator CA.
   string oiak_cert = 2;
 
-  // PEM-encoded owner initial DevID certificate signed by the
-  // switch owner/administrator CA.
+  // [Optional] PEM-encoded owner initial DevID certificate signed by the
+  // switch owner/administrator CA. Will be empty if `idevid_cert` was not
+  // provided in GetIakCertResponse earlier in the workflow.
   string oidevid_cert = 3;
 
   // SSL profile for which the certs will be assigned.