Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enrollz_biz_test: ignore unexported fields from x509.VerifyOptions #50

Merged
merged 1 commit into from
Nov 27, 2024
Merged

enrollz_biz_test: ignore unexported fields from x509.VerifyOptions #50

merged 1 commit into from
Nov 27, 2024

Conversation

melzhan
Copy link
Contributor

@melzhan melzhan commented Nov 27, 2024

Upstream Go CL go.dev/cl/628616 adds unexported fields to x509.VerifyOptions, which will make the test fail.

Adding a cmpopts.IgnoreUnexported forward fixes these test failures

@melzhan melzhan requested a review from a team as a code owner November 27, 2024 23:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12059785547

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.885%
Totals Coverage Status
Change from base Build 12041200433: 0.0%
Covered Lines: 318
Relevant Lines: 366
💛 - Coveralls

@melzhan melzhan merged commit 3a0be78 into main Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacf gmacf gmacf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melzhan @coveralls @gmacf