Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Entitymanager and populate security artifacts #12

Merged
merged 14 commits into from
Aug 23, 2023
Merged

Implement Entitymanager and populate security artifacts #12

merged 14 commits into from
Aug 23, 2023

Conversation

gmacf
Copy link
Contributor

@gmacf gmacf commented Aug 15, 2023 •
edited
Loading

This PR implements some basic entitymanager functionality and also reads the keypairs and OVs from disk.

@gmacf gmacf changed the title Implement Entitymanager Implement Entitymanager and read artifacts from disk Aug 15, 2023
@gmacf gmacf changed the title Implement Entitymanager and read artifacts from disk Implement Entitymanager and populate security artifacts Aug 15, 2023
@gmacf gmacf changed the base branch from hines to main August 17, 2023 04:09
sam-homa
sam-homa reviewed Aug 17, 2023
View reviewed changes
server/entitymanager/entitymanager.go Outdated Show resolved Hide resolved
server/entitymanager/entitymanager.go Show resolved Hide resolved
server/entitymanager/entitymanager.go Show resolved Hide resolved
server/entitymanager/entitymanager_test.go Show resolved Hide resolved
marcushines
marcushines reviewed Aug 17, 2023
View reviewed changes
server/entitymanager/entitymanager.go Outdated Show resolved Hide resolved
server/entitymanager/entitymanager_test.go Outdated Show resolved Hide resolved
@gmacf gmacf requested a review from marcushines August 21, 2023 02:47
marcushines
marcushines reviewed Aug 22, 2023
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5945818861

  • 95 of 105 (90.48%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+90.8%) to 90.826%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/entitymanager/entitymanager.go 95 105 90.48%
Totals Coverage Status
Change from base Build 5860904156: 90.8%
Covered Lines: 99
Relevant Lines: 109
💛 - Coveralls

@gmacf gmacf merged commit e26441e into openconfig:main Aug 23, 2023
6 checks passed
@gmacf gmacf deleted the entity branch September 27, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-homa sam-homa sam-homa left review comments

@marcushines marcushines marcushines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmacf @coveralls @sam-homa @marcushines