Update gnsi-acctz.yang #145
Conversation
Remove duplicate container for counters
acctz/gnsi-acctz.yang
Outdated
| (January 1st, 1970 00:00:00 GMT)."; | ||
| } | ||
| "A collection of counters from the gNSI.acctz module. This collection | ||
| augments the existing certz grpc counters"; | ||
|
|
||
| container client-counters { |
There was a problem hiding this comment.
un-indent these children of the counters container?
marcushines
force-pushed
the
marcushines-patch-1
branch
from
50409ba to
fcdce7f
Compare
| for acctz clients and sources."; | ||
| config false; | ||
|
|
||
| leaf last-cleared-on { |
There was a problem hiding this comment.
It's ok for this leaf to no longer exist anywhere?
acctz/gnsi-acctz.yang
Outdated
| @@ -25,6 +25,12 @@ module gnsi-acctz { | |||
| "This module provides a data model for the metadata of the gRPC | |||
| accounting operations on a device."; | |||
|
|
|||
| revision 2023-01-24 { | |||
| description | |||
| "Remove duplicate counter container."; | |||
There was a problem hiding this comment.
"counter" -> "counters"
marcushines
force-pushed
the
marcushines-patch-1
branch
from
fcdce7f to
2d60453
Compare
|
While you are here making these changes we should include a state container in the path. OC style guide, requires a The most common,(but not style guide required grouping) for counters is to use a
Less common, but has precedence in igmp and isis models and is closer to what you have here would be one of the following:
|
|
We're looking at resolving these issues at openconfig/public#1037 Propose to close this PR and move the discussion over there. |
Remove duplicate container for counters