Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification to usage of container .../use-multiple-paths/*bgp/link-bandwidth-ext-community/ #1139

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

rszarecki
Copy link
Contributor

Change Scope

Clarification to usage of container .../use-multiple-paths/ebgp/link-bandwidth-ext-community/

@rszarecki rszarecki requested a review from a team as a code owner June 25, 2024 16:22
@rszarecki rszarecki changed the title Clarification to usage of container .../use-multiple-paths/ebgp/link-bandwidth-ext-community/ Clarification to usage of container .../use-multiple-paths/*bgp/link-bandwidth-ext-community/ Jun 25, 2024
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
@wenovus
Copy link
Contributor

wenovus commented Jun 25, 2024

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Jun 25, 2024

No major YANG version changes in commit d5040ee

@wenovus
Copy link
Contributor

wenovus commented Jun 28, 2024

/gcbrun

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions for grammar and wording of the description updates. I think the content makes sense to me and the negative case description is helpful.

release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
release/models/bgp/openconfig-bgp-common.yang Outdated Show resolved Hide resolved
rszarecki and others added 2 commits October 15, 2024 16:22
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
@dplore
Copy link
Member

dplore commented Oct 17, 2024

/gcbrun

@dplore
Copy link
Member

dplore commented Oct 17, 2024

Thanks for the contribution! LGTM, except there is a version conflict to be fixed.

  oc-ext:openconfig-version "9.7.2";

  revision "2024-07-25" {
    description
      "Clarification to usage of link-bandwidth-ext-community
      container under BGP use-multiple-paths`.";
          reference "9.7.2";
=======
  oc-ext:openconfig-version "9.8.0";

  revision "2024-09-06" {
    description
      "Restore NONE enum value for community-type.";
    reference "9.8.0";
>>>>>>> master
  }

@dplore dplore requested a review from robshakir October 17, 2024 00:08
@dplore dplore self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

5 participants