Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefixing to ACL when conditionals that are part of reusable groupings #1247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

earies
Copy link
Contributor

@earies earies commented Jan 15, 2025

  • (M) release/models/acl/openconfig-acl.yang
    • Add prefixing to when conditionals

Change Scope

Add prefixing to when conditionals that are part of reusable groupings

Current yanglint warnings generated:

libyang warn: Identityref "type" comparison with identity "ACL_IPV6" without prefix, consider adding a prefix or best using "derived-from(-or-self)()" functions.
libyang warn: Previous warning generated by XPath subexpression[13] "type='ACL_IPV6'" with context node "/openconfig-acl:acl/acl-sets/acl-set/acl-entries/acl-entry".
libyang warn: Identityref "type" comparison with identity "ACL_IPV4" without prefix, consider adding a prefix or best using "derived-from(-or-self)()" functions.
libyang warn: Previous warning generated by XPath subexpression[45] "type='ACL_IPV4'" with context node "/openconfig-acl:acl/acl-sets/acl-set/acl-entries/acl-entry".
libyang warn: Identityref "type" comparison with identity "ACL_MIXED" without prefix, consider adding a prefix or best using "derived-from(-or-self)()" functions.

This change is backwards compatible

Platform Implementations

No known change to current implemented functionality

…pings

  * (M) release/models/acl/openconfig-acl.yang
    - Add prefixing to when conditionals
@earies earies requested a review from a team as a code owner January 15, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant