fs2: add iocost statistics #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
approved these changes
Oct 24, 2025
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
I assume we're not interested in cost.vrate?
LGTM overall
Contributor
Author
|
AkihiroSuda
approved these changes
Oct 28, 2025
Member
|
Seems to need rebasing to pass the CI |
tiljeset
force-pushed
the
iocost
branch
2 times, most recently
from
5b9c422 to
e55d70f
Compare
Contributor
Author
Rebased. Need approval to run CI. |
Member
|
CI failing |
Contributor
Author
Oops! I wrote the global |
When the iocost controller is enabled it will emit statistics about its usage in io.stat. Export this when available. This is a no-op when iocost is not enabled. There is a comment that we only expose data which directly maps to cgroups v1. We're already breaking this by adding PSI metrics, so reword this to just indicate that we currently don't recognize the other fields. Signed-off-by: Morten Hein Tiljeset <morten@tiljeset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the iocost controller is enabled it will emit statistics about its usage in io.stat. Export this when available. This is a no-op when iocost is not enabled.
There is a comment that we only expose data which directly maps to cgroups v1. We're already breaking this by adding PSI metrics, so reword this to just indicate that we currently don't recognize the other fields.