feat: add ability to get individual controller stats #53
+757
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav-jain-16
force-pushed
the
44
branch
2 times, most recently
from
f8a0dd5 to
7c07d8a
Compare
Author
|
Hi @kolyshkin |
Author
|
Hi @haircommander |
Contributor
|
would love to see some unit tests, and maybe even a POC of it being used in an end user project like CRI-O |
Author
I have added the unit tests
I'm not very familiar with codebase of CRI-O, but I can get a quick POC in |
sambhav-jain-16
force-pushed
the
44
branch
2 times, most recently
from
9a446c9 to
3bc182c
Compare
Contributor
|
LGTM thank you! |
Author
|
@haircommander metrics output |
Contributor
|
great thanks! cc @kolyshkin @AkihiroSuda @dims @dgrisonnet |
AkihiroSuda
reviewed
Jan 6, 2026
sambhav-jain-16
force-pushed
the
44
branch
2 times, most recently
from
be7f526 to
a8d3912
Compare
kolyshkin
reviewed
Jan 10, 2026
kolyshkin
reviewed
Jan 12, 2026
sambhav-jain-16
force-pushed
the
44
branch
5 times, most recently
from
e9a61a9 to
5a20778
Compare
Author
|
I updated the poc sambhav-jain-16/cadvisor#3 and CI is green with integration tests and unit tests |
This adds methods to retrieve statistics for individual cgroup controllers (CPU, memory, pids, IO, hugetlb, rdma, misc) instead of requiring all stats to be fetched at once. This enables tools like cadvisor to collect specific metrics with different housekeeping intervals, reducing computational overhead. Fixes: opencontainers#44 Signed-off-by: Sambhav Jain <jnsmbhv@gmail.com>
kolyshkin
requested changes
Jan 17, 2026
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Forgot to send the review comments. PTAL @sambhav-jain-16
Comment on lines
+349
to
373
| func (m *LegacyManager) Stats(opts *cgroups.StatsOptions) (*cgroups.Stats, error) { | ||
| m.mu.Lock() | ||
| defer m.mu.Unlock() | ||
|
|
||
| // Default: query all controllers (same as original GetStats behavior) | ||
| controllers := cgroups.AllControllers | ||
| if opts != nil && opts.Controllers != 0 { | ||
| controllers = opts.Controllers | ||
| } | ||
|
|
||
| stats := cgroups.NewStats() | ||
| for _, sys := range legacySubsystems { | ||
| path := m.paths[sys.Name()] | ||
| if path == "" { | ||
| continue | ||
| } | ||
|
|
||
| // Filter based on controller type | ||
| if sys.ID()&controllers == 0 { | ||
| continue | ||
| } | ||
|
|
||
| if err := sys.GetStats(path, stats); err != nil { | ||
| return nil, err | ||
| } |
Contributor
There was a problem hiding this comment.
I'd rather replace all this with something like
fsMgr, err := fs.NewManager(m.cgroups, m.paths)
if err != nil {
return nil, err
}
return fsMgr.Stats(opts)(unless I'm missing something)
Comment on lines
+233
to
+255
| // String returns the controller name. | ||
| func (c Controller) String() string { | ||
| switch c { | ||
| case CPU: | ||
| return "cpu" | ||
| case Memory: | ||
| return "memory" | ||
| case Pids: | ||
| return "pids" | ||
| case IO: | ||
| return "io" | ||
| case HugeTLB: | ||
| return "hugetlb" | ||
| case RDMA: | ||
| return "rdma" | ||
| case Misc: | ||
| return "misc" | ||
| case CPUSet: | ||
| return "cpuset" | ||
| default: | ||
| panic("unknown controller") | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add methods to retrieve statistics for individual cgroup controllers
(CPU, memory, pids, IO, hugetlb, rdma, misc) instead of requiring all
stats to be fetched at once.
Fixes: #44