Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: do not fail on report generation failure #419

Merged
merged 1 commit into from
Jun 23, 2023
Merged

conformance: do not fail on report generation failure #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions conformance/reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,12 @@ func (reporter *HTMLReporter) save(snapshot *specSnapshot) {
}

func (reporter *HTMLReporter) SpecSuiteDidEnd(summary *types.SuiteSummary) {
if err := reporter.writeReport(summary); err != nil {
log.Printf("WARNING: cannot write HTML summary report: %v", err)
}
}

func (reporter *HTMLReporter) writeReport(summary *types.SuiteSummary) error {
reporter.endTime = time.Now()
reporter.EndTimeString = reporter.endTime.Format("Jan 2 15:04:05.000 -0700 MST")
reporter.RunTime = reporter.endTime.Sub(reporter.startTime).String()
Expand All @@ -539,26 +545,27 @@ func (reporter *HTMLReporter) SpecSuiteDidEnd(summary *types.SuiteSummary) {

t, err := template.New("report").Parse(htmlTemplate)
if err != nil {
log.Fatal(err)
return fmt.Errorf("cannot parse report template: %v", err)
}

htmlReportFilenameAbsPath, err := filepath.Abs(reporter.htmlReportFilename)
if err != nil {
log.Fatal(err)
return err
}

htmlReportFile, err := os.Create(htmlReportFilenameAbsPath)
if err != nil {
log.Fatal(err)
return err
}
defer htmlReportFile.Close()

err = t.ExecuteTemplate(htmlReportFile, "report", &reporter)
if err != nil {
log.Fatal(err)
return err
}

fmt.Printf("HTML report was created: %s", htmlReportFilenameAbsPath)
return nil
}

//unused by HTML reporter
Expand Down