Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content of manifest doesn't match the spec with image files build-diagram.png and run-diagram.png #343

Closed
TrumanLing opened this issue Sep 27, 2016 · 6 comments · Fixed by #357

Comments

@TrumanLing
Copy link

TrumanLing commented Sep 27, 2016

From the spec definition and according to my understanding of this spec, it should not appear field for manifests array.

@vbatts
Copy link
Member

vbatts commented Sep 27, 2016

I noticed this too. It produces the right then when make docs is run, but it ought to be checked in

@TrumanLing
Copy link
Author

TrumanLing commented Sep 28, 2016

@vbatts I have tried to run make docs, it didn't make sense. Also, I checked Makefile, there is no any operation with image files build-diagram.png and run-diagram.png.

@philips I found you checked in these two image files on May 24,2016, would you please update them? Of course, I am willing to do it, but I have no the original and editable files.

@wking
Copy link
Contributor

wking commented Sep 28, 2016

On Tue, Sep 27, 2016 at 11:40:19PM -0700, TrumanLing wrote:

@philips I found you checked in these two image files on May
24,2016, would please update them? Of course, I am willing to do it,
but I have no the original and editable file.

The commit message and PR landing them point at Google docs (74114b7,
#86). I pinged @philips asking for a change 1, because I can't edit
those docs.

philips pushed a commit to philips/image-spec that referenced this issue Sep 30, 2016
Based on rename of layer. fixes opencontainers#343
@philips
Copy link
Contributor

philips commented Sep 30, 2016

Fixed in #357.

philips pushed a commit to philips/image-spec that referenced this issue Sep 30, 2016
Based on rename of layer. fixes opencontainers#343

Signed-off-by: Brandon Philips <brandon.philips@coreos.com>
@TrumanLing
Copy link
Author

TrumanLing commented Oct 18, 2016

@vbatts @philips is it OK for an OCI image taking a manifest list? And I think it is mismatched with description This specification defines how to create an OCI Image, which will generally be done by a build system, and output an image manifest, a set of filesystem layers, and an image configuration in the specification. Do we need to reopen it?

@wking
Copy link
Contributor

wking commented Oct 18, 2016

On Mon, Oct 17, 2016 at 06:36:20PM -0700, TrumanLing wrote:

@vbatts @philips is it OK for an OCI image taking a manifest list?
And I think it is mismatched with description This specification defines how to create an OCI Image, which will generally be done by a build system, and output an image manifest, a set of filesystem layers, and an image configuration in the specification.

I'd like to see a manifest in the image too 1, and it's good to have
the image match the surrounding text. @jonboulle feels like the
manifest link in the “high-level components” line a bit futher down is
complicated enough without mentioning manifest lists 2. Maybe we
could have a new entry in the “high-level components” list talking
about multi-platform images and linking to manifest-list.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants