specs-go/v1/config: omitempty is ineffective on Created
#626
Milestone
Comments
|
@lucab how about submitting a patch to pointer-ify this one? |
lucab
added a commit
to lucab/image-spec
that referenced
this issue
Apr 3, 2017
PR opencontainers#534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers#626 Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
|
Ack, up at #633. |
dattgoswami9lk5g
added a commit
to dattgoswami9lk5g/bremlinr
that referenced
this issue
Jun 6, 2022
PR #534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers/image-spec#626 Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
7c00d
pushed a commit
to 7c00d/J1nHyeockKim
that referenced
this issue
Jun 6, 2022
PR #534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers/image-spec#626 Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
7c00d
added a commit
to 7c00d/J1nHyeockKim
that referenced
this issue
Jun 6, 2022
PR #534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers/image-spec#626 Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
laventuraw
added a commit
to laventuraw/Kihara-tony0
that referenced
this issue
Jun 6, 2022
PR #534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers/image-spec#626 Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
tomalopbsr0tt
added a commit
to tomalopbsr0tt/fabiojosej
that referenced
this issue
Oct 6, 2022
PR #534 changed Created from string to time.Time field. This neutered the `omitempty` property on it, as a missing field is now populated as the default time.Time value. This commit turns the field into a pointer, in order to keep the empty-value semantic for `omitempty`. Fixes opencontainers/image-spec#626 Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#534 changed
Createdfrom string to time.Time field. This neutered theomitemptyproperty on it, as a missing field is now populated as the default time.Time value (0000-01-01).Ref: golang/go#11939
/cc @jlbutler as #534 author
The text was updated successfully, but these errors were encountered: