-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref file name identical to tag #327
Conversation
On Mon, Sep 19, 2016 at 03:50:21AM -0700, xiekeyang wrote:
This is not true. See moby/moby#25779, which currently defaults |
Here I'm unclear to
What is the layout for same tag case? Do you mean a layout includes images: hello-world:latest and busybox:latest ? |
On Tue, Sep 20, 2016 at 02:09:19AM -0700, xiekeyang wrote:
Yeah. The example @stevvooe gives in moby/moby#25779 is to have |
@wking I think we can add language to this effect that makes the common ref-tag mapping clear but allows for other mappings. |
On Tue, Sep 20, 2016 at 12:06:28PM -0700, Stephen Day wrote:
I think the “In the wild…” line below already makes this use case A common use case is to use “tag” names as refs. which repaces the current “representing” with “use… as”. |
For example, an image may have a tag for different versions or builds of the software. | ||
In the wild you often see "tags" like "v1.0.0-vendor.0", "2.0.0-debug", etc. | ||
In the wild you often see "tags" like "v1.0.0-vendor.0", "2.0.0-debug", etc which is(not MUST) identical to ref file names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still seems a bit awkward to me. This this suggestion is too brief, how about leaving the current there lines as they stand in master to convey (by sentence):
- Refs are often used for tags.
- Images are often tagged by version or build.
- Tags look like {examples}.
Then add an additional sentence to cover your additional point:
Those tags will often be represented in an image-layout repository with matching refs like "v1.0.0-vendor.0”, “2.0.0-debug”, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Signed-off-by: xiekeyang <xiekeyang@huawei.com>
14597a3 looks good to me.
|
PTAL. |
The ref file name should be identical to tag it presents, from implementation side. And this had better to be amended in
Implementor's Note
section.Signed-off-by: xiekeyang xiekeyang@huawei.com